Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: mojo/shell/public/cpp/shell_client.h

Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@28lifecycle2
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/lib/shell_connection.cc ('k') | mojo/shell/tests/connect/connect_test_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/shell_client.h
diff --git a/mojo/shell/public/cpp/shell_client.h b/mojo/shell/public/cpp/shell_client.h
index 2eb9079efe2ab7dd0c43234e18cf022c5e51d8f5..36b93874ed492e54707ffcaf50174ef13ce7cc61 100644
--- a/mojo/shell/public/cpp/shell_client.h
+++ b/mojo/shell/public/cpp/shell_client.h
@@ -42,11 +42,10 @@ class ShellClient {
// underlying pipe closed. The default implementation returns false.
virtual bool AcceptConnection(Connection* connection);
- // Called when ShellConnection's pipe to the Mojo Shell is closed.
- //
- // Returning true from this method will cause ...
- // The default implementation returns true.
- virtual bool ShellConnectionLost();
+ // Called when ShellConnection's ShellClient binding (i.e. the pipe the
+ // Mojo Shell has to talk to us over) is closed. A shell client may use this
+ // as a signal to terminate.
+ virtual void ShellConnectionLost();
private:
DISALLOW_COPY_AND_ASSIGN(ShellClient);
« no previous file with comments | « mojo/shell/public/cpp/lib/shell_connection.cc ('k') | mojo/shell/tests/connect/connect_test_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698