mojo/shell/public/cpp/lib/connector_impl.h - Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/public/cpp/lib/connector_impl.h

Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@28lifecycle2

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/public/cpp/lib/connector_impl.h

diff --git a/mojo/shell/public/cpp/lib/connector_impl.h b/mojo/shell/public/cpp/lib/connector_impl.h

index 0e0a3482a01a15e539e72b4db2d939528a0bd00a..44f37b1556463566d9a4ee040ce6b721cf3c8b9c 100644

--- a/mojo/shell/public/cpp/lib/connector_impl.h

+++ b/mojo/shell/public/cpp/lib/connector_impl.h

@@ -15,8 +15,7 @@ namespace mojo {

class ConnectorImpl : public Connector {

public:

explicit ConnectorImpl(shell::mojom::ConnectorPtrInfo unbound_state);

- ConnectorImpl(shell::mojom::ConnectorPtr connector,

- const base::Closure& connection_error_closure);

+ explicit ConnectorImpl(shell::mojom::ConnectorPtr connector);

~ConnectorImpl() override;

private:

« no previous file with comments | « mojo/services/tracing/tracing_app.cc ('k') | mojo/shell/public/cpp/lib/connector_impl.cc » ('j') | no next file with comments »