mojo/services/tracing/tracing_app.h - Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/tracing/tracing_app.h

Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@28lifecycle2

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/services/tracing/tracing_app.h

diff --git a/mojo/services/tracing/tracing_app.h b/mojo/services/tracing/tracing_app.h

index eb5934ab2366a438b48336b7ca8d967de8ba579c..17f41322ed633909a6909440c88d5f3e8109ad47 100644

--- a/mojo/services/tracing/tracing_app.h

+++ b/mojo/services/tracing/tracing_app.h

@@ -34,7 +34,7 @@ class TracingApp

private:

// mojo::ShellClient implementation.

bool AcceptConnection(mojo::Connection* connection) override;

- bool ShellConnectionLost() override;

+ void ShellConnectionLost() override;

// mojo::InterfaceFactory<TraceCollector> implementation.

void Create(mojo::Connection* connection,

« no previous file with comments | « mojo/services/network/network_service_delegate.cc ('k') | mojo/services/tracing/tracing_app.cc » ('j') | no next file with comments »