Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 17611: Combine smi and overflow checks for count operations. (Closed)

Created:
11 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

This is really Kasper's change that I took because Kasper is unavailable to work on it today. Combine smi and overflow checks for count operations. This generates more compact code because we are always using big encodings of jumps and also it has the effect of spacing jumps. This can be done for other overflow and smi checks. I'll do that separately. Committed: http://code.google.com/p/v8/source/detail?r=1055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3 lines) Patch
M src/assembler-ia32.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/assembler-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/codegen-ia32.cc View 2 chunks +28 lines, -3 lines 0 comments Download
M src/disasm-ia32.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M src/register-allocator-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/register-allocator-ia32.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 11 months ago (2009-01-12 16:27:51 UTC) #1
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-12 16:40:43 UTC) #2
LGTM.  I can't think of any place else that it could be used yet.

Powered by Google App Engine
This is Rietveld 408576698