Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761033002: MD Settings: fix closure compile by adding missing assert() dependency (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix closure compile by adding missing assert() dependency TBR=dschuyler@chromium.org BUG=531750 Committed: https://chromium.googlesource.com/chromium/src/+/bc45d7da02c175c541098865cf5aa650efcd266f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/on_startup_page/compiled_resources.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Dan Beam
4 years, 9 months ago (2016-03-03 21:19:34 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc45d7da02c175c541098865cf5aa650efcd266f Cr-Commit-Position: refs/heads/master@{#379089}
4 years, 9 months ago (2016-03-03 21:24:14 UTC) #3
Dan Beam
4 years, 9 months ago (2016-03-03 21:24:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bc45d7da02c175c541098865cf5aa650efcd266f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698