src/client/linux/minidump_writer/minidump_writer.cc - Issue 1761023002: Add an optional root prefix to Linux dumpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/client/linux/minidump_writer/minidump_writer.cc

Issue 1761023002: Add an optional root prefix to Linux dumpers (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/client/linux/minidump_writer/minidump_writer.cc

diff --git a/src/client/linux/minidump_writer/minidump_writer.cc b/src/client/linux/minidump_writer/minidump_writer.cc

index 04327338b81d55cc84c97d2898bd1d0ad25f39b7..3103761f6033eff1ac7d048499f991b61a92d5d5 100644

--- a/src/client/linux/minidump_writer/minidump_writer.cc

+++ b/src/client/linux/minidump_writer/minidump_writer.cc

@@ -567,7 +567,7 @@ class MinidumpWriter {

char file_name[NAME_MAX];

char file_path[NAME_MAX];

- LinuxDumper::GetMappingEffectiveNameAndPath(

+ dumper_->GetMappingEffectiveNameAndPath(

mapping, file_path, sizeof(file_path), file_name, sizeof(file_name));

const size_t file_name_len = my_strlen(file_name);