Fix SkiaServe gpu JSON to work with any reordering algorithm

Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761003004

Committed: https://skia.googlesource.com/skia/+/e43f7e67b69dcae80b2110a7ebfe62f167c4953f

[joshua.litt, 2016-03-04 15:49:07]

Description was changed from

==========
Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
==========

to

==========
Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-04 16:03:43]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-03-04 16:03:43]

ptal

[jcgregorio, 2016-03-04 16:06:18]

https://codereview.chromium.org/1761003004/diff/20001/tools/skiaserve/skiaser...
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1761003004/diff/20001/tools/skiaserve/skiaser...
tools/skiaserve/skiaserve.cpp:90: // TODO Add option to bind this strictly to an
address, e.g. localhost, for security.
The TODO can be removed, that's what the --address cmd line flag does.

[joshualitt, 2016-03-04 17:37:12]

On 2016/03/04 16:06:18, jcgregorio wrote:
>
https://codereview.chromium.org/1761003004/diff/20001/tools/skiaserve/skiaser...
> File tools/skiaserve/skiaserve.cpp (right):
> 
>
https://codereview.chromium.org/1761003004/diff/20001/tools/skiaserve/skiaser...
> tools/skiaserve/skiaserve.cpp:90: // TODO Add option to bind this strictly to
an
> address, e.g. localhost, for security.
> The TODO can be removed, that's what the --address cmd line flag does.

commend removed

[ethannicholas, 2016-03-04 18:24:07]

https://codereview.chromium.org/1761003004/diff/60001/tools/debugger/SkDebugC...
File tools/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/1761003004/diff/60001/tools/debugger/SkDebugC...
tools/debugger/SkDebugCanvas.cpp:454: SkDEBUGCODE(bool parsingSuccessful =
)reader.parse(at->toJson(i).c_str(),
Better to use SkAssertResult and do this in one step?

[joshualitt, 2016-03-04 18:34:54]

On 2016/03/04 18:24:07, ethannicholas wrote:
>
https://codereview.chromium.org/1761003004/diff/60001/tools/debugger/SkDebugC...
> File tools/debugger/SkDebugCanvas.cpp (right):
> 
>
https://codereview.chromium.org/1761003004/diff/60001/tools/debugger/SkDebugC...
> tools/debugger/SkDebugCanvas.cpp:454: SkDEBUGCODE(bool parsingSuccessful =
> )reader.parse(at->toJson(i).c_str(),
> Better to use SkAssertResult and do this in one step?

feedback inc

[ethannicholas, 2016-03-04 18:35:33]

lgtm

[joshualitt, 2016-03-04 18:35:40]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-03-04 18:35:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761003004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761003004/80001

[commit-bot: I haz the power, 2016-03-04 18:45:07]

Description was changed from

==========
Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e43f7e67b69dcae80b2110a7ebfe62f167c4953f
==========

[commit-bot: I haz the power, 2016-03-04 18:45:08]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e43f7e67b69dcae80b2110a7ebfe62f167c4953f