Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: trunk/src/chrome/browser/drive/drive_notification_manager.cc

Issue 17610004: Revert 208315 "Make use of InvalidationService" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/drive/drive_notification_manager.h" 5 #include "chrome/browser/drive/drive_notification_manager.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/drive/drive_notification_observer.h" 8 #include "chrome/browser/drive/drive_notification_observer.h"
9 #include "chrome/browser/invalidation/invalidation_service.h"
10 #include "chrome/browser/invalidation/invalidation_service_factory.h"
11 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sync/profile_sync_service.h"
11 #include "chrome/browser/sync/profile_sync_service_factory.h"
12 #include "google/cacheinvalidation/types.pb.h" 12 #include "google/cacheinvalidation/types.pb.h"
13 13
14 namespace drive { 14 namespace drive {
15 15
16 namespace { 16 namespace {
17 17
18 // The polling interval time is used when XMPP is disabled. 18 // The polling interval time is used when XMPP is disabled.
19 const int kFastPollingIntervalInSecs = 60; 19 const int kFastPollingIntervalInSecs = 60;
20 20
21 // The polling interval time is used when XMPP is enabled. Theoretically 21 // The polling interval time is used when XMPP is enabled. Theoretically
(...skipping 13 matching lines...) Expand all
35 polling_timer_(true /* retain_user_task */, false /* is_repeating */), 35 polling_timer_(true /* retain_user_task */, false /* is_repeating */),
36 weak_ptr_factory_(this) { 36 weak_ptr_factory_(this) {
37 RegisterDriveNotifications(); 37 RegisterDriveNotifications();
38 RestartPollingTimer(); 38 RestartPollingTimer();
39 } 39 }
40 40
41 DriveNotificationManager::~DriveNotificationManager() {} 41 DriveNotificationManager::~DriveNotificationManager() {}
42 42
43 void DriveNotificationManager::Shutdown() { 43 void DriveNotificationManager::Shutdown() {
44 // Unregister for Drive notifications. 44 // Unregister for Drive notifications.
45 invalidation::InvalidationService* invalidation_service = 45 ProfileSyncService* profile_sync_service =
46 invalidation::InvalidationServiceFactory::GetForProfile(profile_); 46 ProfileSyncServiceFactory::GetForProfile(profile_);
47 if (!invalidation_service || !push_notification_registered_) { 47 if (!profile_sync_service || !push_notification_registered_) {
48 return; 48 return;
49 } 49 }
50 50
51 // We unregister the handler without updating unregistering our IDs on 51 profile_sync_service->UpdateRegisteredInvalidationIds(
52 // purpose. See the class comment on the InvalidationService interface for 52 this, syncer::ObjectIdSet());
53 // more information. 53 profile_sync_service->UnregisterInvalidationHandler(this);
54 invalidation_service->UnregisterInvalidationHandler(this);
55 } 54 }
56 55
57 void DriveNotificationManager::OnInvalidatorStateChange( 56 void DriveNotificationManager::OnInvalidatorStateChange(
58 syncer::InvalidatorState state) { 57 syncer::InvalidatorState state) {
59 push_notification_enabled_ = (state == syncer::INVALIDATIONS_ENABLED); 58 push_notification_enabled_ = (state == syncer::INVALIDATIONS_ENABLED);
60 if (push_notification_enabled_) { 59 if (push_notification_enabled_) {
61 DVLOG(1) << "XMPP Notifications enabled"; 60 DVLOG(1) << "XMPP Notifications enabled";
62 } else { 61 } else {
63 DVLOG(1) << "XMPP Notifications disabled (state=" << state << ")"; 62 DVLOG(1) << "XMPP Notifications disabled (state=" << state << ")";
64 } 63 }
65 FOR_EACH_OBSERVER(DriveNotificationObserver, observers_, 64 FOR_EACH_OBSERVER(DriveNotificationObserver, observers_,
66 OnPushNotificationEnabled(push_notification_enabled_)); 65 OnPushNotificationEnabled(push_notification_enabled_));
67 } 66 }
68 67
69 void DriveNotificationManager::OnIncomingInvalidation( 68 void DriveNotificationManager::OnIncomingInvalidation(
70 const syncer::ObjectIdInvalidationMap& invalidation_map) { 69 const syncer::ObjectIdInvalidationMap& invalidation_map) {
71 DVLOG(2) << "XMPP Drive Notification Received"; 70 DVLOG(2) << "XMPP Drive Notification Received";
72 DCHECK_EQ(1U, invalidation_map.size()); 71 DCHECK_EQ(1U, invalidation_map.size());
73 const invalidation::ObjectId object_id( 72 const invalidation::ObjectId object_id(
74 ipc::invalidation::ObjectSource::COSMO_CHANGELOG, 73 ipc::invalidation::ObjectSource::COSMO_CHANGELOG,
75 kDriveInvalidationObjectId); 74 kDriveInvalidationObjectId);
76 DCHECK_EQ(1U, invalidation_map.count(object_id)); 75 DCHECK_EQ(1U, invalidation_map.count(object_id));
77 76
78 // TODO(dcheng): Only acknowledge the invalidation once the fetch has 77 // TODO(dcheng): Only acknowledge the invalidation once the fetch has
79 // completed. http://crbug.com/156843 78 // completed. http://crbug.com/156843
80 invalidation::InvalidationService* invalidation_service = 79 ProfileSyncService* profile_sync_service =
81 invalidation::InvalidationServiceFactory::GetForProfile(profile_); 80 ProfileSyncServiceFactory::GetForProfile(profile_);
82 DCHECK(invalidation_service); 81 profile_sync_service->AcknowledgeInvalidation(
83 invalidation_service->AcknowledgeInvalidation(
84 invalidation_map.begin()->first, 82 invalidation_map.begin()->first,
85 invalidation_map.begin()->second.ack_handle); 83 invalidation_map.begin()->second.ack_handle);
86 84
87 NotifyObserversToUpdate(NOTIFICATION_XMPP); 85 NotifyObserversToUpdate(NOTIFICATION_XMPP);
88 } 86 }
89 87
90 void DriveNotificationManager::AddObserver( 88 void DriveNotificationManager::AddObserver(
91 DriveNotificationObserver* observer) { 89 DriveNotificationObserver* observer) {
92 observers_.AddObserver(observer); 90 observers_.AddObserver(observer);
93 } 91 }
(...skipping 29 matching lines...) Expand all
123 121
124 // Note that polling_timer_ is not a repeating timer. Restarting manually 122 // Note that polling_timer_ is not a repeating timer. Restarting manually
125 // here is better as XMPP may be received right before the polling timer is 123 // here is better as XMPP may be received right before the polling timer is
126 // fired (i.e. we don't notify observers twice in a row). 124 // fired (i.e. we don't notify observers twice in a row).
127 RestartPollingTimer(); 125 RestartPollingTimer();
128 } 126 }
129 127
130 void DriveNotificationManager::RegisterDriveNotifications() { 128 void DriveNotificationManager::RegisterDriveNotifications() {
131 DCHECK(!push_notification_enabled_); 129 DCHECK(!push_notification_enabled_);
132 130
133 invalidation::InvalidationService* invalidation_service = 131 ProfileSyncService* profile_sync_service =
134 invalidation::InvalidationServiceFactory::GetForProfile(profile_); 132 ProfileSyncServiceFactory::GetForProfile(profile_);
135 if (!invalidation_service) 133 if (!profile_sync_service)
136 return; 134 return;
137 135
138 invalidation_service->RegisterInvalidationHandler(this); 136 profile_sync_service->RegisterInvalidationHandler(this);
139 syncer::ObjectIdSet ids; 137 syncer::ObjectIdSet ids;
140 ids.insert(invalidation::ObjectId( 138 ids.insert(invalidation::ObjectId(
141 ipc::invalidation::ObjectSource::COSMO_CHANGELOG, 139 ipc::invalidation::ObjectSource::COSMO_CHANGELOG,
142 kDriveInvalidationObjectId)); 140 kDriveInvalidationObjectId));
143 invalidation_service->UpdateRegisteredInvalidationIds(this, ids); 141 profile_sync_service->UpdateRegisteredInvalidationIds(this, ids);
144 push_notification_registered_ = true; 142 push_notification_registered_ = true;
145 OnInvalidatorStateChange(invalidation_service->GetInvalidatorState()); 143 OnInvalidatorStateChange(profile_sync_service->GetInvalidatorState());
146 144
147 UMA_HISTOGRAM_BOOLEAN("Drive.PushNotificationRegistered", 145 UMA_HISTOGRAM_BOOLEAN("Drive.PushNotificationRegistered",
148 push_notification_registered_); 146 push_notification_registered_);
149 } 147 }
150 148
151 // static 149 // static
152 std::string DriveNotificationManager::NotificationSourceToString( 150 std::string DriveNotificationManager::NotificationSourceToString(
153 NotificationSource source) { 151 NotificationSource source) {
154 switch (source) { 152 switch (source) {
155 case NOTIFICATION_XMPP: 153 case NOTIFICATION_XMPP:
156 return "NOTIFICATION_XMPP"; 154 return "NOTIFICATION_XMPP";
157 case NOTIFICATION_POLLING: 155 case NOTIFICATION_POLLING:
158 return "NOTIFICATION_POLLING"; 156 return "NOTIFICATION_POLLING";
159 } 157 }
160 158
161 NOTREACHED(); 159 NOTREACHED();
162 return ""; 160 return "";
163 } 161 }
164 162
165 } // namespace drive 163 } // namespace drive
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698