Issue 17610: Move spills inside SmiOperation and GenericBinaryOperation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17610: Move spills inside SmiOperation and GenericBinaryOperation (Closed)

Created:
11 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Move spills inside SmiOperation and GenericBinaryOperation Committed: http://code.google.com/p/v8/source/detail?r=1059

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	src/codegen-ia32.cc	View	1	4 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

This must fail a bunch of tests. The frame state (at least in debug builds) ...

11 years, 11 months ago (2009-01-12 15:58:16 UTC) #2

William Hesse

11 years, 11 months ago (2009-01-13 09:09:35 UTC) #3

OK, passes all tests.

http://codereview.chromium.org/17610/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/17610/diff/1/2#newcode4139
Line 4139: VirtualFrame::SpilledScope spilled_scope(this);
On 2009/01/12 15:58:16, Kevin Millikin wrote:
> This spill has to be eliminated.

Done.

Expand Messages | Collapse Messages