Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1760973002: Initialize ICU before running any of the //net fuzzers. (Closed)

Created:
4 years, 9 months ago by eroman
Modified:
4 years, 9 months ago
Reviewers:
mmoroz
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize ICU before running any of the //net fuzzers. ICU is used internally by //net through GURL, however needs to be first initialized by calling base::i18n::InitializeICU(). Do this initialization via a static initializer for any //net fuzzer to be safe, since it is not always obvious when this dependency is used. BUG=591677 Committed: https://crrev.com/02b4fe56060de5d37e3a2a36afdfdd4944bb544a Cr-Commit-Position: refs/heads/master@{#379270}

Patch Set 1 #

Patch Set 2 : mark as testonly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -28 lines) Patch
M net/BUILD.gn View 1 16 chunks +28 lines, -2 lines 0 comments Download
M net/DEPS View 1 chunk +1 line, -5 lines 0 comments Download
A net/base/fuzzer_test_support.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M net/base/registry_controlled_domains/get_domain_and_registry_fuzzer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/ftp/ftp_directory_listing_fuzzer.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eroman
4 years, 9 months ago (2016-03-03 18:18:38 UTC) #2
mmoroz
LGTM Thanks for pointing this out and fixing!
4 years, 9 months ago (2016-03-04 11:11:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760973002/20001
4 years, 9 months ago (2016-03-04 11:11:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 12:15:25 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 12:16:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02b4fe56060de5d37e3a2a36afdfdd4944bb544a
Cr-Commit-Position: refs/heads/master@{#379270}

Powered by Google App Engine
This is Rietveld 408576698