Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: runtime/vm/service.cc

Issue 1760963002: Print isolate properly in debug output for IsolateRunnable events. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 4fbb0c523408c37143c991d33b293f046a9ce556..5ded7a2fc3b3d3795d4d3b2bd0afceaa736e94a8 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1030,11 +1030,12 @@ void Service::HandleEvent(ServiceEvent* event) {
params.AddProperty("streamId", stream_id);
params.AddProperty("event", event);
}
- PostEvent(stream_id, event->KindAsCString(), &js);
+ PostEvent(event->isolate(), stream_id, event->KindAsCString(), &js);
}
-void Service::PostEvent(const char* stream_id,
+void Service::PostEvent(Isolate* isolate,
+ const char* stream_id,
const char* kind,
JSONStream* event) {
ASSERT(stream_id != NULL);
@@ -1063,7 +1064,6 @@ void Service::PostEvent(const char* stream_id,
list_values[1] = &json_cobj;
if (FLAG_trace_service) {
- Isolate* isolate = Isolate::Current();
const char* isolate_name = "<no current isolate>";
if (isolate != NULL) {
isolate_name = isolate->name();
« no previous file with comments | « runtime/vm/service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698