Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1760963002: Print isolate properly in debug output for IsolateRunnable events. (Closed)

Created:
4 years, 9 months ago by turnidge
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print isolate properly in debug output for IsolateRunnable events. Be a bit more verbose in test_helper to help us track down some test hangs. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5d83c5ec9b2912a6b45d846555383b48e7d94833

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +33 lines, -31 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 9 months ago (2016-03-03 17:35:09 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-03 17:49:26 UTC) #3
turnidge
4 years, 9 months ago (2016-03-03 17:52:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5d83c5ec9b2912a6b45d846555383b48e7d94833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698