Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1760943003: Prepare ActivityLogConverterStrategyTest for ES2015 Function name reform (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare ActivityLogConverterStrategyTest for ES2015 Function name reform One test case in this test is trying to test the output for an anonymous function, but in ES2015 functions assigned to properties in object literals are given the name of the property. Wrapping the function literal in a comma expression avoids the name inference, so that this test will continue to pass once V8 ships the new semantics. BUG=v8:3699 Committed: https://crrev.com/0cf9f97e579fc4c696f1af0255a86d48e41cc0fa Cr-Commit-Position: refs/heads/master@{#379144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 9 months ago (2016-03-03 23:19:18 UTC) #2
Devlin
lgtm
4 years, 9 months ago (2016-03-03 23:24:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760943003/1
4 years, 9 months ago (2016-03-03 23:24:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 00:00:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 00:02:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cf9f97e579fc4c696f1af0255a86d48e41cc0fa
Cr-Commit-Position: refs/heads/master@{#379144}

Powered by Google App Engine
This is Rietveld 408576698