Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1760933002: rewrite TArray test to not delete an SkSTArray via a SkTArray pointer. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

rewrite TArray test to not delete an SkSTArray via a SkTArray pointer. This should decouple our thinking around SkTArray, SkSTArray, vector, allocators, etc. from getting sized-deleter clean. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760933002 Committed: https://skia.googlesource.com/skia/+/862110042d715214b484e643194336c0f0b28659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -49 lines) Patch
M tests/TArrayTest.cpp View 1 chunk +35 lines, -49 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760933002/1
4 years, 9 months ago (2016-03-03 17:18:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 17:35:20 UTC) #6
mtklein_C
4 years, 9 months ago (2016-03-03 17:35:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760933002/1
4 years, 9 months ago (2016-03-03 17:35:59 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-03 17:36:00 UTC) #11
bsalomon
lgtm
4 years, 9 months ago (2016-03-03 17:47:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:48:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/862110042d715214b484e643194336c0f0b28659

Powered by Google App Engine
This is Rietveld 408576698