Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1760833002: docs: simplify the gclient wording in mac_build_instructions.md (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: simplify the gclient wording in mac_build_instructions.md gclient is just part of a bigger package called 'depot_tools', and a bunch of other tools from depot_tools are necessary to get the job done, not just gclient. So like the iOS build instructions, just point to depot_tools page. BUG=None R=sdefresne@chromium.org Committed: https://crrev.com/166ecadbad315a70811b6918625a96aeb94feda5 Cr-Commit-Position: refs/heads/master@{#379002}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M docs/mac_build_instructions.md View 1 chunk +2 lines, -7 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
https://codereview.chromium.org/1760833002/diff/1/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/1760833002/diff/1/docs/mac_build_instructions.md#newcode8 docs/mac_build_instructions.md:8: * [Xcode](https://developer.apple.com/xcode) 5+. Should be 3 spaces or just ...
4 years, 9 months ago (2016-03-03 07:37:23 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/1760833002/diff/1/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/1760833002/diff/1/docs/mac_build_instructions.md#newcode8 docs/mac_build_instructions.md:8: * [Xcode](https://developer.apple.com/xcode) 5+. On 2016/03/03 at 07:37:23, tfarina ...
4 years, 9 months ago (2016-03-03 11:50:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760833002/1
4 years, 9 months ago (2016-03-03 12:13:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 12:22:37 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 12:23:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/166ecadbad315a70811b6918625a96aeb94feda5
Cr-Commit-Position: refs/heads/master@{#379002}

Powered by Google App Engine
This is Rietveld 408576698