third_party/dom_distiller_js/README.chromium - Issue 176083002: Use boilerpipe-based dom-distiller-js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/dom_distiller_js/README.chromium

Issue 176083002: Use boilerpipe-based dom-distiller-js (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« third_party/dom_distiller_js/LICENSE ('K') | « third_party/dom_distiller_js/LICENSE ('k') | third_party/dom_distiller_js/js/domdistiller.js » ('j') | third_party/dom_distiller_js/update_domdistiller_js.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Name: dom-distiller-js

	2 URL: https://code.google.com/p/dom-distiller

	3 Version: 5fc15eb7483a

	4 License: BSD
	Yaron 2014/02/26 02:50:50 Actually, why did you create this as BSD? Is it va Actually, why did you create this as BSD? Is it valid? The original library was Apache2. cjhopman 2014/02/27 02:43:09 My understanding: BSD is the default Chromium lice Show quoted text On 2014/02/26 02:50:50, Yaron wrote: > Actually, why did you create this as BSD? Is it valid? The original library was > Apache2. My understanding: BSD is the default Chromium license and so the dom-distiller project (on google code) uses the BSD license. Parts of that project (particularly boilerpipe-core) are also available under other licenses (i.e. Apache 2.0). This change requires a LICENSE file in this folder and that will basically say what I've just said a above (in many more words). nyquist 2014/03/03 18:08:57 For new readers, see: https://codereview.chromium. Show quoted text On 2014/02/27 02:43:09, cjhopman wrote: > On 2014/02/26 02:50:50, Yaron wrote: > > Actually, why did you create this as BSD? Is it valid? The original library > was > > Apache2. > My understanding: BSD is the default Chromium license and so the dom-distiller > project (on google code) uses the BSD license. Parts of that project > (particularly boilerpipe-core) are also available under other licenses (i.e. > Apache 2.0). > > This change requires a LICENSE file in this folder and that will basically say > what I've just said a above (in many more words). For new readers, see: https://codereview.chromium.org/177283005/
	5 Security Critical: yes

	6

	7 Description:

	8 Dom Distiller is a java library that extracts article content from a web page.
	nyquist 2014/02/26 00:30:15 Could you add a description as to how to update th Could you add a description as to how to update this? cjhopman 2014/02/27 02:43:09 Done. Show quoted text On 2014/02/26 00:30:15, nyquist wrote: > Could you add a description as to how to update this? Done.
	9 It is compiled to javascript with GWT.

	10

	11 Local Modifications: None

OLD	NEW