Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 17608010: Remove SVGLangSpace IDL interface (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, pdr, f(malita), Stephen Chennney, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Remove SVGLangSpace IDL interface Remove SVGLangSpace IDL interface and move its attributes to SVGElement to match the latest specification and simplify inheritance in SVG: https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement BUG=253477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -121 lines) Patch
M Source/core/svg/SVGAElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDefsElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDescElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGDescElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/svg/SVGLangSpace.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/svg/SVGLineElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLineElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPolyElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGRectElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGTitleElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTitleElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-25 15:04:30 UTC) #1
Stephen Chennney
lgtm
7 years, 6 months ago (2013-06-25 15:12:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17608010/1
7 years, 6 months ago (2013-06-25 15:12:51 UTC) #3
haraken
LGTM
7 years, 6 months ago (2013-06-25 15:13:35 UTC) #4
pdr.
On 2013/06/25 15:13:35, haraken wrote: > LGTM LGTM3!
7 years, 6 months ago (2013-06-25 15:42:54 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 15:53:04 UTC) #6
Message was sent while issue was closed.
Change committed as 153007

Powered by Google App Engine
This is Rietveld 408576698