Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.h

Issue 1760773004: Add "Open with <ARC-app-name>" items to the context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.h
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.h b/chrome/browser/renderer_context_menu/render_view_context_menu.h
index 43b95e59527b778295720e0c7734c0d9e5b5dfe1..d6062e0090ace33eb0cf3199559829e35e617cd7 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.h
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.h
@@ -28,6 +28,7 @@
#include "chrome/browser/extensions/menu_manager.h"
#endif
+class OpenWithMenuObserver;
class PrintPreviewContextMenuObserver;
class Profile;
class SpellingMenuObserver;
@@ -122,6 +123,7 @@ class RenderViewContextMenu : public RenderViewContextMenuBase {
void AppendDeveloperItems();
void AppendDevtoolsForUnpackedExtensions();
void AppendLinkItems();
+ void AppendOpenWithLinkItems();
void AppendImageItems();
void AppendAudioItems();
void AppendCanvasItems();
@@ -192,6 +194,9 @@ class RenderViewContextMenu : public RenderViewContextMenuBase {
scoped_ptr<SpellingOptionsSubMenuObserver> spelling_options_submenu_observer_;
#endif
+ // An observer that handles "Open with <app>" items.
+ scoped_ptr<RenderViewContextMenuObserver> open_with_menu_observer_;
dcheng 2016/04/21 04:20:45 Nit: std::unique_ptr
Yusuke Sato 2016/04/22 05:27:48 Done.
+
#if defined(ENABLE_PRINT_PREVIEW)
// An observer that disables menu items when print preview is active.
scoped_ptr<PrintPreviewContextMenuObserver> print_preview_menu_observer_;

Powered by Google App Engine
This is Rietveld 408576698