Add "Open with <ARC-app-name>" items to the context menu

chrome/browser/chromeos/arc/open_with_menu_controller_delegate_unittest.cc

Index: chrome/browser/chromeos/arc/open_with_menu_controller_delegate_unittest.cc
diff --git a/chrome/browser/chromeos/arc/open_with_menu_controller_delegate_unittest.cc b/chrome/browser/chromeos/arc/open_with_menu_controller_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..90615a40d9ce3015758a1906856b2832ac3f33b4
--- /dev/null
+++ b/chrome/browser/chromeos/arc/open_with_menu_controller_delegate_unittest.cc
@@ -0,0 +1,135 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/stringprintf.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/chromeos/arc/open_with_menu_controller_delegate.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+namespace {
+
+void BuildHandlersMap(size_t num_apps,
+                      std::unordered_map<int, UrlHandlerInfoPtr>* out_map,
+                      int* out_sub_menu_parent_command_id) {
+  out_map->clear();
+  *out_sub_menu_parent_command_id = -2;
+  mojo::Array<UrlHandlerInfoPtr> handlers;
+  for (size_t i = 0; i < num_apps; ++i) {
+    UrlHandlerInfoPtr p = UrlHandlerInfo::New();
+    p->name = base::StringPrintf("App %zu", i);
+    handlers.push_back(std::move(p));
+  }
+  OpenWithMenuControllerDelegate::BuildHandlersMapForTesting(
+      IDC_CONTENT_CONTEXT_OPEN_WITH1,
+      IDC_CONTENT_CONTEXT_OPEN_WITH_LAST - IDC_CONTENT_CONTEXT_OPEN_WITH1 + 1,
+      std::move(handlers), out_map, out_sub_menu_parent_command_id);
+}
+
+}  // namespace
+
+// All tests in this file assume that 4 and 10 IDC command IDs are reserved
+// for the main and sub menus, respectively.
+
+TEST(OpenWithMenuControllerDelegateTest, TestGetCommandIdsToEnable) {
+  std::unordered_map<int, UrlHandlerInfoPtr> result;
+  int sub_menu_parent_command_id;
+
+  BuildHandlersMap(0, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(0U, result.size());
+  EXPECT_EQ(-1, sub_menu_parent_command_id);
+
+  BuildHandlersMap(1, &result, &sub_menu_parent_command_id);
+  ASSERT_EQ(1U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  EXPECT_EQ(-1, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+
+  BuildHandlersMap(2, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(2U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  EXPECT_EQ(-1, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+
+  BuildHandlersMap(3, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(3U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH3));
+  EXPECT_EQ(-1, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  EXPECT_EQ("App 2", result[IDC_CONTENT_CONTEXT_OPEN_WITH3]->name);
+
+  // Test if app names will overflow to the sub menu.
+  BuildHandlersMap(4, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(4U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  // In this case, IDC_CONTENT_CONTEXT_OPEN_WITH3 should be hidden.
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_OPEN_WITH_LAST, sub_menu_parent_command_id);
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP2));
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  EXPECT_EQ("App 2", result[IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1]->name);
+  EXPECT_EQ("App 3", result[IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP2]->name);
+
+  BuildHandlersMap(11, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(11U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_OPEN_WITH_LAST, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  for (size_t i = 0; i < 9; ++i) {
+    ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1 + i))
+        << i;
+  }
+
+  // The main and sub menus can show up to 12 (=3+10-1) app names.
+  BuildHandlersMap(12, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(12U, result.size());
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_OPEN_WITH_LAST, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  for (size_t i = 0; i < 10; ++i) {
+    const int id = IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1 + i;
+    ASSERT_EQ(1U, result.count(id)) << i;
+    EXPECT_EQ(base::StringPrintf("App %zu", i + 2), result[id]->name) << i;
+  }
+
+  BuildHandlersMap(13, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(12U, result.size());  // still 12
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_OPEN_WITH_LAST, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  for (size_t i = 0; i < 10; ++i) {  // still 10
+    const int id = IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1 + i;
+    ASSERT_EQ(1U, result.count(id)) << i;
+    EXPECT_EQ(base::StringPrintf("App %zu", i + 2), result[id]->name) << i;
+  }
+
+  BuildHandlersMap(1000, &result, &sub_menu_parent_command_id);
+  EXPECT_EQ(12U, result.size());  // still 12
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH1));
+  ASSERT_EQ(1U, result.count(IDC_CONTENT_CONTEXT_OPEN_WITH2));
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_OPEN_WITH_LAST, sub_menu_parent_command_id);
+  EXPECT_EQ("App 0", result[IDC_CONTENT_CONTEXT_OPEN_WITH1]->name);
+  EXPECT_EQ("App 1", result[IDC_CONTENT_CONTEXT_OPEN_WITH2]->name);
+  for (size_t i = 0; i < 10; ++i) {  // still 10
+    const int id = IDC_CONTENT_CONTEXT_OPEN_WITH_ARC_APP1 + i;
+    ASSERT_EQ(1U, result.count(id)) << i;
+    EXPECT_EQ(base::StringPrintf("App %zu", i + 2), result[id]->name) << i;
+  }
+}
+
+}  // namespace arc