Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1760693002: Updated devices with updates from github repository. (Closed)

Created:
4 years, 9 months ago by Jonathan Garbee
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated devices with updates from github repository. BUG=591171 Committed: https://crrev.com/3462e690304786b5db00051953cb1f09af474641 Cr-Commit-Position: refs/heads/master@{#380032}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json View 2 chunks +73 lines, -1 line 1 comment Download

Messages

Total messages: 13 (3 generated)
Jonathan Garbee
PTAL
4 years, 9 months ago (2016-03-02 18:33:13 UTC) #2
dgozman
https://codereview.chromium.org/1760693002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json File third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json (right): https://codereview.chromium.org/1760693002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json#newcode502 third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json:502: "device-pixel-ratio": 1.5, Wasn't this reverted back to 1.4?
4 years, 9 months ago (2016-03-02 20:57:21 UTC) #3
Jonathan Garbee
On 2016/03/02 at 20:57:21, dgozman wrote: > https://codereview.chromium.org/1760693002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json > File third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json (right): > > https://codereview.chromium.org/1760693002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json#newcode502 ...
4 years, 9 months ago (2016-03-02 21:06:34 UTC) #4
Jonathan Garbee
On 2016/03/02 at 21:06:34, Jonathan Garbee wrote: > On 2016/03/02 at 20:57:21, dgozman wrote: > ...
4 years, 9 months ago (2016-03-02 21:13:49 UTC) #5
Jonathan Garbee
On 2016/03/02 at 21:13:49, Jonathan Garbee wrote: > On 2016/03/02 at 21:06:34, Jonathan Garbee wrote: ...
4 years, 9 months ago (2016-03-08 22:59:13 UTC) #6
dgozman
lgtm
4 years, 9 months ago (2016-03-08 23:16:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760693002/1
4 years, 9 months ago (2016-03-09 00:36:28 UTC) #9
paulirish
nice stuff. thanks garbee!
4 years, 9 months ago (2016-03-09 01:22:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 02:12:07 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 02:13:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3462e690304786b5db00051953cb1f09af474641
Cr-Commit-Position: refs/heads/master@{#380032}

Powered by Google App Engine
This is Rietveld 408576698