Cache API: Pass origin to platform, rather than DatabaseIdentifier

Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org

Committed: https://crrev.com/d5f03152d47419ff779de8ad40a4ca997e430ebc
Cr-Commit-Position: refs/heads/master@{#379021}

[jsbell, 2016-03-02 19:50:54]

Description was changed from

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=michaeln@chromium.org,mkwst@chromium.org
==========

to

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org
==========

[jsbell, 2016-03-02 19:50:55]

jsbell@chromium.org changed reviewers:
- michaeln@chromium.org

[jsbell, 2016-03-02 19:52:25]

mkwst@ - can you review?

(I've got more of these coming)

https://codereview.chromium.org/1760673003/diff/1/content/renderer/renderer_b...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/1760673003/diff/1/content/renderer/renderer_b...
content/renderer/renderer_blink_platform_impl.cc:434: const GURL origin =
blink::WebStringToGURL(security_origin.toString());
It looks like this WebSecurityOrigin->WebString->GURL conversion is done
elsewhere, but it also seems like that could be more elegant...?

[Mike West, 2016-03-02 20:58:40]

LGTM, with the caveat that it would be nice if you kept things as `url::Origin`
all the way through, rather than landing on GURL. Happy to see that refactoring
another time, though. Doesn't need to block this patch.

https://codereview.chromium.org/1760673003/diff/1/content/renderer/renderer_b...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/1760673003/diff/1/content/renderer/renderer_b...
content/renderer/renderer_blink_platform_impl.cc:434: const GURL origin =
blink::WebStringToGURL(security_origin.toString());
On 2016/03/02 at 19:52:25, jsbell wrote:
> It looks like this WebSecurityOrigin->WebString->GURL conversion is done
elsewhere, but it also seems like that could be more elegant...?

If you make `origin` a `url::Origin`, you'll get the conversion from
`WebSecurityOrigin` for ~free. That's more work elsewhere, of course...

[jsbell, 2016-03-02 21:24:34]

On 2016/03/02 20:58:40, Mike West wrote:
> LGTM, with the caveat that it would be nice if you kept things as
`url::Origin`
> all the way through, rather than landing on GURL. Happy to see that
refactoring
> another time, though. Doesn't need to block this patch.

Cool. Since this is strictly better (IMHO) I'll land as-is, even though it's not
urgent.

Filed https://crbug.com/591482 to track url::Origin conversion.

[jsbell, 2016-03-02 21:26:42]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-03-02 21:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760673003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760673003/1

[commit-bot: I haz the power, 2016-03-02 21:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 21:42:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jsbell, 2016-03-02 23:19:25]

jsbell@chromium.org changed reviewers:
+ jam@chromium.org

[jsbell, 2016-03-02 23:19:26]

jam@ - OWNERS review for content/renderer/renderer_blink_platform_impl.* ?

[jam, 2016-03-03 16:38:12]

lgtm

[jam, 2016-03-03 16:38:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-03-03 16:38:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760673003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760673003/1

[commit-bot: I haz the power, 2016-03-03 16:44:08]

Description was changed from

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org
==========

to

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org
==========

[commit-bot: I haz the power, 2016-03-03 16:44:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-03 16:45:46]

Description was changed from

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org
==========

to

==========
Cache API: Pass origin to platform, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin.

BUG=591240
R=mkwst@chromium.org

Committed: https://crrev.com/d5f03152d47419ff779de8ad40a4ca997e430ebc
Cr-Commit-Position: refs/heads/master@{#379021}
==========

[commit-bot: I haz the power, 2016-03-03 16:45:47]

Patchset 1 (id:??) landed as
https://crrev.com/d5f03152d47419ff779de8ad40a4ca997e430ebc
Cr-Commit-Position: refs/heads/master@{#379021}