Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: url/mojo/mojo_gurl_unittest.cc

Issue 1760643004: Add mojo struct traits for GURL so that it can be sent over mojoms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to mojom namespace and add security owners Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/mojo/mojo_gurl_unittest.cc
diff --git a/url/mojo/mojo_gurl_unittest.cc b/url/mojo/mojo_gurl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e743df25f89478f84d67271a1869c165af96affa
--- /dev/null
+++ b/url/mojo/mojo_gurl_unittest.cc
@@ -0,0 +1,71 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/macros.h"
+#include "mojo/public/cpp/bindings/binding.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/mojo/url_test.mojom.h"
+
+namespace url {
+
+class UrlTestImpl : public mojom::UrlTest {
+ public:
+ explicit UrlTestImpl(mojo::InterfaceRequest<url::mojom::UrlTest> request)
+ : binding_(this, std::move(request)) {
+ }
+
+ // UrlTest:
+ void Bounce(const GURL& in, const BounceCallback& callback) override {
+ callback.Run(in);
+ }
+
+ private:
+ mojo::Binding<UrlTest> binding_;
+};
+
+// Mojo version of chrome IPC test in
+// content/common/common_param_traits_unittest.cc
+TEST(MojoGURLTest, Basic) {
+ base::MessageLoop message_loop;
+
+ mojom::UrlTestPtr proxy;
+ UrlTestImpl impl(GetProxy(&proxy));
+
+ const char* serialize_cases[] = {
+ "http://www.google.com/",
+ "http://user:pass@host.com:888/foo;bar?baz#nop",
+ };
+
+ for (size_t i = 0; i < arraysize(serialize_cases); i++) {
+ GURL input(serialize_cases[i]);
+ GURL output;
+ EXPECT_TRUE(proxy->Bounce(input, &output));
+
+ // We want to test each component individually to make sure its range was
+ // correctly serialized and deserialized, not just the spec.
+ EXPECT_EQ(input.possibly_invalid_spec(), output.possibly_invalid_spec());
+ EXPECT_EQ(input.is_valid(), output.is_valid());
+ EXPECT_EQ(input.scheme(), output.scheme());
+ EXPECT_EQ(input.username(), output.username());
+ EXPECT_EQ(input.password(), output.password());
+ EXPECT_EQ(input.host(), output.host());
+ EXPECT_EQ(input.port(), output.port());
+ EXPECT_EQ(input.path(), output.path());
+ EXPECT_EQ(input.query(), output.query());
+ EXPECT_EQ(input.ref(), output.ref());
+ }
+
+ // Test an excessively long GURL.
+ {
+ const std::string url = std::string("http://example.org/").append(
+ mojo::kMaxURLChars + 1, 'a');
+ GURL input(url.c_str());
+ GURL output;
+ EXPECT_TRUE(proxy->Bounce(input, &output));
+ EXPECT_TRUE(output.is_empty());
+ }
+}
+
+} // namespace url
« no previous file with comments | « url/mojo/gurl.typemap ('k') | url/mojo/url.mojom » ('j') | url/mojo/url_gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698