Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: url/mojo/url_gurl_struct_traits.h

Issue 1760643004: Add mojo struct traits for GURL so that it can be sent over mojoms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/mojo/url_gurl_struct_traits.h
diff --git a/url/mojo/url_gurl_struct_traits.h b/url/mojo/url_gurl_struct_traits.h
new file mode 100644
index 0000000000000000000000000000000000000000..88b1dae4d2d9018837cc8ffe552610df8b080714
--- /dev/null
+++ b/url/mojo/url_gurl_struct_traits.h
@@ -0,0 +1,39 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/string_piece.h"
+#include "url/gurl.h"
+#include "url/mojo/url.mojom.h"
+
+namespace mojo {
+
+// copied from content/public/common/content_constants.cc: make that file use
+// this definition.
+const size_t kMaxUrlChars = 2 * 1024 * 1024;
+
+template <>
+struct StructTraits<url::mojom::Url, GURL> {
+ static base::StringPiece url(const GURL& r) {
+ if (r.possibly_invalid_spec().length() > kMaxUrlChars || !r.is_valid()) {
+ return base::StringPiece();
+ }
+
+ return base::StringPiece(r.possibly_invalid_spec().c_str(),
+ r.possibly_invalid_spec().length());
+ }
+ static bool Read(url::mojom::Url::Reader r, GURL* out) {
+ if (r.url().length() > kMaxUrlChars) {
+ *out = GURL();
+ return false;
+ }
+ *out = GURL(r.url());
+ if (!r.url().empty() && !out->is_valid()) {
+ *out = GURL();
+ return false;
+ }
+ return true;
+ }
+};
+
+}

Powered by Google App Engine
This is Rietveld 408576698