url/mojo/url.mojom - Issue 1760643004: Add mojo struct traits for GURL so that it can be sent over mojoms.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/mojo/url.mojom

Issue 1760643004: Add mojo struct traits for GURL so that it can be sent over mojoms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gn check Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module gpu.mojom;	5 module url;
	Ken Rockot(use gerrit already) 2016/03/03 05:23:28 I think this is fine as is, but IMHO we should rea I think this is fine as is, but IMHO we should really be consistent with mojom namespaces (i know, i know). I also think if we do that, the outer namespace should match between the mojom type and the typemapped type. So because in this case GURL is in the global namespace, I would argue this should just be module mojom. I would also personally prefer URL over Url, but I see that's against style guide recommendations... jam 2016/03/03 16:09:04 ah I forgot, added mojom. GURL is in global namesp Show quoted text On 2016/03/03 05:23:28, Ken Rockot wrote: > I think this is fine as is, but IMHO we should really be consistent with mojom > namespaces (i know, i know). I also think if we do that, the outer namespace > should match between the mojom type and the typemapped type. So because in this > case GURL is in the global namespace, I would argue this should just be module > mojom. ah I forgot, added mojom. GURL is in global namespace because it's before we had the convention of code in src\foo should be in foo namespace, and no one bothered to update it. Show quoted text > > I would also personally prefer URL over Url, but I see that's against style > guide recommendations... ditto
6	6

7 [Native]	7 struct Url {

8 struct Capabilities;	8 string url;

	9 };

OLD	NEW

« no previous file with comments | « url/mojo/mojo_gurl_unittest.cc ('k') | url/mojo/url_gurl.h » ('j') | no next file with comments »