Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 1760583003: Remove unused tools and unused includes of SkImageDecoder (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2525 lines) Patch
M gyp/tools.gyp View 1 3 chunks +0 lines, -23 lines 0 comments Download
M tools/VisualBench/VisualInteractiveModule.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/find_bad_images_in_skps.py View 1 chunk +0 lines, -197 lines 0 comments Download
D tools/imgconv.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/json/SkJSONCanvas.h View 1 chunk +0 lines, -292 lines 0 comments Download
D tools/json/SkJSONCanvas.cpp View 1 chunk +0 lines, -918 lines 0 comments Download
D tools/json/SkJSONRenderer.h View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/json/SkJSONRenderer.cpp View 1 chunk +0 lines, -972 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/pinspect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/test_image_decoder.cpp View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
msarett
https://codereview.chromium.org/1760583003/diff/1/tools/find_bad_images_in_skps.py File tools/find_bad_images_in_skps.py (left): https://codereview.chromium.org/1760583003/diff/1/tools/find_bad_images_in_skps.py#oldcode1 tools/find_bad_images_in_skps.py:1: #!/usr/bin/env python This one may be interesting to look ...
4 years, 9 months ago (2016-03-03 00:47:02 UTC) #3
scroggo
lgtm https://codereview.chromium.org/1760583003/diff/1/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (left): https://codereview.chromium.org/1760583003/diff/1/tools/skiaserve/skiaserve.cpp#oldcode20 tools/skiaserve/skiaserve.cpp:20: // To get image decoders linked in we ...
4 years, 9 months ago (2016-03-03 16:14:09 UTC) #4
scroggo
> Remove unused tools This message is partially descriptive - it *also* removes SkImageDecoder from ...
4 years, 9 months ago (2016-03-03 16:18:33 UTC) #5
msarett
https://codereview.chromium.org/1760583003/diff/1/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (left): https://codereview.chromium.org/1760583003/diff/1/tools/skiaserve/skiaserve.cpp#oldcode20 tools/skiaserve/skiaserve.cpp:20: // To get image decoders linked in we have ...
4 years, 9 months ago (2016-03-03 16:18:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760583003/20001
4 years, 9 months ago (2016-03-03 16:19:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760583003/20001
4 years, 9 months ago (2016-03-03 16:20:19 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 16:38:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/464d210875ccf24687027fa1b401b9ba257e2a27

Powered by Google App Engine
This is Rietveld 408576698