Clean up reparenting in SVGUseElement::expand*

Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding the call to cloneDataFromElement(), and make the other
one static (while renaming it.)

BUG=589682
Committed: https://crrev.com/24b6b4cb2ea2fb34f67dab65f60a53616945d6a5
Cr-Commit-Position: refs/heads/master@{#378992}

[fs, 2016-03-02 14:52:50]

Description was changed from

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two and make it
static (while renaming it.)

BUG=589682
==========

to

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding cloneDataFromElement, and make the other one static
(while renaming it.)

BUG=589682
==========

[fs, 2016-03-02 14:53:36]

Description was changed from

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding cloneDataFromElement, and make the other one static
(while renaming it.)

BUG=589682
==========

to

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding the call to cloneDataFromElement(), and make the other
one static (while renaming it.)

BUG=589682
==========

[fs, 2016-03-02 15:47:40]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-03-02 21:24:35]

LGTM

https://codereview.chromium.org/1760553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGUseElement.cpp (right):

https://codereview.chromium.org/1760553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGUseElement.cpp:598: static void
removeAttributesFromReplacementElement(SVGElement& to)
It looks like this area is primed to extract out the common code between the two
expand functions. If that's the case, please don't waste your time on my nits
since they will be resolved in a followup.

Nits: Can you move the comments about what is being removed up here? The name
'to' is a little confusing too.

[fs, 2016-03-02 21:30:01]

https://codereview.chromium.org/1760553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGUseElement.cpp (right):

https://codereview.chromium.org/1760553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGUseElement.cpp:598: static void
removeAttributesFromReplacementElement(SVGElement& to)
On 2016/03/02 at 21:24:35, pdr wrote:
> It looks like this area is primed to extract out the common code between the
two expand functions. If that's the case, please don't waste your time on my
nits since they will be resolved in a followup.
> 
> Nits: Can you move the comments about what is being removed up here? The name
'to' is a little confusing too.

I suspect this function might stay alive even after followups, so I better fix
these nits up.

[fs, 2016-03-03 10:13:24]

The CQ bit was checked by fs@opera.com

[fs, 2016-03-03 10:13:25]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1760553002/#ps20001
(title: "Move comment; rename parameter.")

[commit-bot: I haz the power, 2016-03-03 10:13:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760553002/20001

[commit-bot: I haz the power, 2016-03-03 10:18:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 10:20:24]

Description was changed from

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding the call to cloneDataFromElement(), and make the other
one static (while renaming it.)

BUG=589682
==========

to

==========
Clean up reparenting in SVGUseElement::expand*

Add a helper moveChildrenToReplacementElement() and use that instead of
an open-coded loop.
Split transferUseAttributesToReplacedElement() into two, getting rid of
one by open-coding the call to cloneDataFromElement(), and make the other
one static (while renaming it.)

BUG=589682

Committed: https://crrev.com/24b6b4cb2ea2fb34f67dab65f60a53616945d6a5
Cr-Commit-Position: refs/heads/master@{#378992}
==========

[commit-bot: I haz the power, 2016-03-03 10:20:25]

Patchset 2 (id:??) landed as
https://crrev.com/24b6b4cb2ea2fb34f67dab65f60a53616945d6a5
Cr-Commit-Position: refs/heads/master@{#378992}