Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 176053002: [WebsiteSettings] Change permission bubble API to adapt to new mocks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add multi-download bubble changes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.h
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.h b/chrome/browser/ui/website_settings/permission_bubble_manager.h
index 09850253f9163bf3b72211ed363ef0951c13ba43..d784541bd9e21dbc42832221152cabd20bfabfda 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.h
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.h
@@ -35,15 +35,25 @@ class PermissionBubbleManager
virtual ~PermissionBubbleManager();
- // Add a new request to the permission bubble. Ownership of the request
+ // Adds a new request to the permission bubble. Ownership of the request
// remains with the caller. The caller must arrange for the request to
// outlive the PermissionBubbleManager. If a bubble is visible when this
// call is made, the request will be queued up and shown after the current
- // bubble closes.
+ // bubble closes. A request with message text identical to an outstanding
+ // request will receive a RequestFinished call immediately and not be added.
virtual void AddRequest(PermissionBubbleRequest* request);
- // Set the active view for the permission bubble. If this is NULL, it
- // means the permission bubble is no longer showing.
+ // Cancels an outstanding request. This may have different effects depending
+ // on what is going on with the bubble. If the request is pending, it will be
+ // removed and never shown. If the request is showing, it will continue to be
+ // shown, but the user's action won't be reported back to the request object.
+ // In some circumstances, we can remove the request from the bubble, and may
+ // do so. The caller may delete the request after calling this method.
+ virtual void CancelRequest(PermissionBubbleRequest* request);
+
+ // Sets the active view for the permission bubble. If this is NULL, it
+ // means any existing permission bubble can no longer be shown. Does not
+ // take ownership of the view.
virtual void SetView(PermissionBubbleView* view) OVERRIDE;
protected:

Powered by Google App Engine
This is Rietveld 408576698