Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 176053002: [WebsiteSettings] Change permission bubble API to adapt to new mocks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add multi-download bubble changes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/desktop_notification_service.cc
diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc
index 9dc9d9824d6b59ce454404c8ffa8e40f8fe73614..a64f80f62f856e8ab7d7111036306a92fd9af8ee 100644
--- a/chrome/browser/notifications/desktop_notification_service.cc
+++ b/chrome/browser/notifications/desktop_notification_service.cc
@@ -77,10 +77,11 @@ class NotificationPermissionRequest : public PermissionBubbleRequest {
virtual ~NotificationPermissionRequest();
// PermissionBubbleDelegate:
+ virtual int GetIconID() const OVERRIDE;
virtual base::string16 GetMessageText() const OVERRIDE;
virtual base::string16 GetMessageTextFragment() const OVERRIDE;
- virtual base::string16 GetAlternateAcceptButtonText() const OVERRIDE;
- virtual base::string16 GetAlternateDenyButtonText() const OVERRIDE;
+ virtual bool HasUserGesture() const OVERRIDE;
+ virtual GURL GetRequestingHostname() const OVERRIDE;
virtual void PermissionGranted() OVERRIDE;
virtual void PermissionDenied() OVERRIDE;
virtual void Cancelled() OVERRIDE;
@@ -126,6 +127,10 @@ NotificationPermissionRequest::NotificationPermissionRequest(
NotificationPermissionRequest::~NotificationPermissionRequest() {}
+int NotificationPermissionRequest::GetIconID() const {
+ return IDR_INFOBAR_DESKTOP_NOTIFICATIONS;
+}
+
base::string16 NotificationPermissionRequest::GetMessageText() const {
return l10n_util::GetStringFUTF16(IDS_NOTIFICATION_PERMISSIONS,
display_name_);
@@ -136,14 +141,13 @@ NotificationPermissionRequest::GetMessageTextFragment() const {
return l10n_util::GetStringUTF16(IDS_NOTIFICATION_PERMISSIONS_FRAGMENT);
}
-base::string16
-NotificationPermissionRequest::GetAlternateAcceptButtonText() const {
- return l10n_util::GetStringUTF16(IDS_NOTIFICATION_PERMISSION_YES);
dewittj 2014/02/27 00:19:43 Does this mean that Yes/No is the default?
Greg Billock 2014/02/27 00:39:44 Current plan is that the bubbles will always say "
+bool NotificationPermissionRequest::HasUserGesture() const {
+ // TODO(gbillock): plumb this through
+ return false;
dewittj 2014/02/27 00:19:43 Chrome requires that the requestPermission method
Greg Billock 2014/02/27 00:39:44 Yes. I discovered this doing the plumbing. :-) I t
}
-base::string16
-NotificationPermissionRequest::GetAlternateDenyButtonText() const {
- return l10n_util::GetStringUTF16(IDS_NOTIFICATION_PERMISSION_NO);
+GURL NotificationPermissionRequest::GetRequestingHostname() const {
+ return origin_;
}
void NotificationPermissionRequest::PermissionGranted() {
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698