Issue 1760523008: Don't use List caches for lists of primitive values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1760523008: Don't use List caches for lists of primitive values. (Closed)

Created:
4 years, 9 months ago by scheglov

Modified:
4 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use List caches for lists of primitive values. Caching is useful for lists of objects, but lists of primitive values it is wasteful to create copies when we can read directly from the underlaying buffer. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3fe1282f756d2f0bc4f2060435fcf55cfbe0aa8b

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -24 lines)			Patch
	M	pkg/analyzer/lib/src/summary/flat_buffers.dart	View		3 chunks	+9 lines, -24 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 9 months ago (2016-03-03 16:04:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fe1282f756d2f0bc4f2060435fcf55cfbe0aa8b (presubmit successful).