Add support for compression filters in the mojo dart:io

Add support for compression filters in the mojo dart:io

Fixes #691

- Add native implementation of zlib filters from standalone VM.
- Add filters apptest.

R=zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/c0fe8a5c1a358da514dfeb34097b854b890c42a5

[Cutch, 2016-03-02 21:48:47]

Description was changed from

==========
Add support for filters in the mojo dart:io

BUG=
==========

to

==========
Add support for compression filters in the mojo dart:io

Fixes #691

- Add native implementation of zlib filters from standalone VM.
- Add filters apptest.
==========

[Cutch, 2016-03-02 21:48:47]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[zra, 2016-03-02 23:30:40]

lgtm

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/apptests/dart_app...
File mojo/dart/apptests/dart_apptests/lib/src/filter_apptests.dart (right):

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/apptests/dart_app...
mojo/dart/apptests/dart_apptests/lib/src/filter_apptests.dart:1: // Copyright
2015 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/embedder/mojo_io_...
File mojo/dart/embedder/mojo_io_natives.cc (right):

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/embedder/mojo_io_...
mojo/dart/embedder/mojo_io_natives.cc:130: static void EndFilter(Dart_Handle
filter_obj, Filter* filter) {
This method of deleting the filter relies on the Dart library code calling
_FilterImpl.end(), otherwise the filter will leak. This should really be deleted
in the finalizer for a weak persistent handle set up by
SetFilterPointerNativeField(), but for now, I guess we should probably just use
the same code as upstream.

[Cutch, 2016-03-03 15:46:56]

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/apptests/dart_app...
File mojo/dart/apptests/dart_apptests/lib/src/filter_apptests.dart (right):

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/apptests/dart_app...
mojo/dart/apptests/dart_apptests/lib/src/filter_apptests.dart:1: // Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/03/02 23:30:40, zra wrote:
> 2016

Done.

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/embedder/mojo_io_...
File mojo/dart/embedder/mojo_io_natives.cc (right):

https://codereview.chromium.org/1760523007/diff/1/mojo/dart/embedder/mojo_io_...
mojo/dart/embedder/mojo_io_natives.cc:130: static void EndFilter(Dart_Handle
filter_obj, Filter* filter) {
On 2016/03/02 23:30:40, zra wrote:
> This method of deleting the filter relies on the Dart library code calling
> _FilterImpl.end(), otherwise the filter will leak. This should really be
deleted
> in the finalizer for a weak persistent handle set up by
> SetFilterPointerNativeField(), but for now, I guess we should probably just
use
> the same code as upstream.

Acknowledged.

[Cutch, 2016-03-03 15:47:20]

Description was changed from

==========
Add support for compression filters in the mojo dart:io

Fixes #691

- Add native implementation of zlib filters from standalone VM.
- Add filters apptest.
==========

to

==========
Add support for compression filters in the mojo dart:io

Fixes #691

- Add native implementation of zlib filters from standalone VM.
- Add filters apptest.

R=zra@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/c0fe8a5c1a358da514dfeb34097...
==========

[Cutch, 2016-03-03 15:47:22]

Committed patchset #2 (id:20001) manually as
c0fe8a5c1a358da514dfeb34097b854b890c42a5 (presubmit successful).