Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 176049: Merge 24568 - Make audio and video in sync while playback rate != 1.0... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com, fbarchard, jam, kylep, awong, darin (slow to review), brettw, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 24568 - Make audio and video in sync while playback rate != 1.0 BUG=20290 TEST=play a video with rate 0.5, audio and video should be in sync This change use the playback rate as a scaling factor for delay introduced in the audio hardware buffer. After we scaled the amount of audio buffer not played, we'll be able to make audio / video in sync again. Review URL: http://codereview.chromium.org/174584 TBR=hclam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
MM chrome/renderer/media/audio_renderer_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
MM media/filters/audio_renderer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 3 months ago (2009-08-31 23:32:08 UTC) #1
Alpha Left Google
11 years, 3 months ago (2009-08-31 23:48:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698