Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1760453002: Remove DeviceManager files from third_party/libjingle build configs. (Closed)

Created:
4 years, 9 months ago by Solis
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DeviceManager files from third_party/libjingle build configs. BUG=webrtc:5615 Committed: https://crrev.com/d8f28037ba276d37296c153ee78346af5e190f4e Cr-Commit-Position: refs/heads/master@{#378738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 3 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760453002/1
4 years, 9 months ago (2016-03-02 10:44:11 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 9 months ago (2016-03-02 10:44:13 UTC) #4
Solis
4 years, 9 months ago (2016-03-02 10:46:41 UTC) #6
kjellander_chromium
Of course! It's much better to remove these before submitting the WebRTC CL. lgtm
4 years, 9 months ago (2016-03-02 12:10:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760453002/1
4 years, 9 months ago (2016-03-02 12:11:00 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 13:36:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760453002/1
4 years, 9 months ago (2016-03-02 13:46:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 13:51:45 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 13:53:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8f28037ba276d37296c153ee78346af5e190f4e
Cr-Commit-Position: refs/heads/master@{#378738}

Powered by Google App Engine
This is Rietveld 408576698