Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1760443002: Moved tests for default value of Empty dir attribute from LayoutTests/imported to LayoutTests/fast/… (Closed)

Created:
4 years, 9 months ago by chakshu
Modified:
4 years, 9 months ago
Reviewers:
tkent, kojii
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved tests for default value of Empty dir attribute from LayoutTests/imported to LayoutTests/fast/dom/Attr/ BUG=578262 Committed: https://crrev.com/adaea6f51d287a5bdfd5d9555b062244fec29543 Cr-Commit-Position: refs/heads/master@{#378736}

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
kojii
lgtm
4 years, 9 months ago (2016-03-02 12:48:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760443002/1
4 years, 9 months ago (2016-03-02 12:48:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 13:47:16 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/adaea6f51d287a5bdfd5d9555b062244fec29543 Cr-Commit-Position: refs/heads/master@{#378736}
4 years, 9 months ago (2016-03-02 13:48:11 UTC) #9
tkent
fast/dom/Attr is a directory for tests for DOM Attr interface. dir-empty-attribute-value.html should be in fast/dom/, ...
4 years, 9 months ago (2016-03-02 23:16:50 UTC) #10
chakshu
On 2016/03/02 23:16:50, tkent wrote: > fast/dom/Attr is a directory for tests for DOM Attr ...
4 years, 9 months ago (2016-03-04 08:59:09 UTC) #11
tkent
On 2016/03/04 at 08:59:09, chakshu.a wrote: > Sorry about that. Have moved them to fast/dom/ ...
4 years, 9 months ago (2016-03-04 09:01:49 UTC) #12
chakshu
4 years, 9 months ago (2016-03-04 09:12:57 UTC) #13
Message was sent while issue was closed.
On 2016/03/04 09:01:49, tkent wrote:
> On 2016/03/04 at 08:59:09, chakshu.a wrote:
> > Sorry about that. Have moved them to fast/dom/ now
> > https://codereview.chromium.org/1765863002/
> 
> Please publish the codereview first.

I assumed it automatically gets published after 
adding reviewers. Sorry !

Powered by Google App Engine
This is Rietveld 408576698