Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1760413003: Revert of Certificate Transparency: Ensure timestamps over 32 bit are handled correctly. (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Certificate Transparency: Ensure timestamps over 32 bit are handled correctly. (patchset #2 id:20001 of https://codereview.chromium.org/1758823002/ ) Reason for revert: Broke sizes due to introducing new static initializers: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/16434/steps/sizes/logs/stdio It seems that you need to include ostream instead of iostream, see crbug.com/94794 Original issue's description: > Certificate Transparency: Ensure timestamps over 32 bit are handled correctly. > > Test + code to ensure that timestamps in STHs are handled correctly when > bigger than 32 bit. > > While I'm at it, change the operator<< overloading for STHs to DebugString. > > BUG= > > Committed: https://crrev.com/989441be7a61fba9338e74302b7f45ac30226cc7 > Cr-Commit-Position: refs/heads/master@{#379276} TBR=davidben@chromium.org,rsleevi@chromium.org,robpercival@chromium.org,eranm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b9fa69cad6684fcc4d045dae9ba097ae5ff77773 Cr-Commit-Position: refs/heads/master@{#379286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M net/cert/ct_log_response_parser.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/cert/ct_log_response_parser_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M net/cert/signed_tree_head.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/signed_tree_head.cc View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of Certificate Transparency: Ensure timestamps over 32 bit are handled correctly.
4 years, 9 months ago (2016-03-04 15:11:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760413003/1
4 years, 9 months ago (2016-03-04 15:11:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 15:12:14 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:13:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9fa69cad6684fcc4d045dae9ba097ae5ff77773
Cr-Commit-Position: refs/heads/master@{#379286}

Powered by Google App Engine
This is Rietveld 408576698