Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1760403003: SDK: Improve the C++ SDK readme, and add some missing docstrings. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SDK: Improve the C++ SDK readme, and add some missing docstrings. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e4abea580bd4f8ac1523501b9e9e356575712ec7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M sdk_build/data/common/download_file_from_google_storage.py View 3 chunks +6 lines, -3 lines 0 comments Download
M sdk_build/data/cpp/README-sdk.md View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-05 00:06:24 UTC) #1
vardhan
lgtm
4 years, 9 months ago (2016-03-05 00:08:25 UTC) #2
viettrungluu
4 years, 9 months ago (2016-03-05 01:06:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4abea580bd4f8ac1523501b9e9e356575712ec7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698