Issue 176037: Fix a DCHECK corner case. Allow (current + new == max) case....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176037: Fix a DCHECK corner case. Allow (current + new == max) case.... (Closed)

Created:
11 years, 3 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a DCHECK corner case. Allow (current + new == max) case. BUG=20673 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25010

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/renderer_host/backing_store_manager.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

LGTM - thanks! http://codereview.chromium.org/176037/diff/1/2 File chrome/browser/renderer_host/backing_store_manager.cc (right): http://codereview.chromium.org/176037/diff/1/2#newcode49 Line 49: // We use this just ...

11 years, 3 months ago (2009-08-31 15:44:52 UTC) #2

Yusuke Sato

11 years, 3 months ago (2009-09-01 01:59:12 UTC) #3

> http://codereview.chromium.org/176037/diff/1/2#newcode49
> Line 49: // We use this
> just remove this line, it's an unfinished comment.

Sure, removed.
Submitting.

Expand Messages | Collapse Messages

Issue 176037: Fix a DCHECK corner case. Allow (current + new == max) case.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages