Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1760363003: Revert of [wasm] Update {i32,i64}.const to use signed leb128 (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
titzer, bradnelson, binji
CC:
v8-reviews_googlegroups.com
Base URL:
http://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Update {i32,i64}.const to use signed leb128 (patchset #3 id:40001 of https://codereview.chromium.org/1765673002/ ) Reason for revert: [Sheriff] Breaks chromium win compile: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/3844/steps/compile/logs/stdio Original issue's description: > [wasm] Update {i32,i64}.const to use signed leb128 > > R=titzer@chromium.org > R=bradnelson@chromium.org > LOG=n > > Committed: https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86 > Cr-Commit-Position: refs/heads/master@{#34471} TBR=bradnelson@chromium.org,titzer@chromium.org,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ec0f451b648e1e13afb00a3d2ec9e1f2e46107ec Cr-Commit-Position: refs/heads/master@{#34482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -322 lines) Patch
M src/wasm/asm-wasm-builder.cc View 6 chunks +6 lines, -11 lines 0 comments Download
M src/wasm/ast-decoder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/decoder.h View 4 chunks +8 lines, -22 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 2 chunks +13 lines, -150 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 10 chunks +49 lines, -49 lines 0 comments Download
M test/unittests/wasm/decoder-unittest.cc View 3 chunks +2 lines, -41 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [wasm] Update {i32,i64}.const to use signed leb128
4 years, 9 months ago (2016-03-04 09:01:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760363003/1
4 years, 9 months ago (2016-03-04 09:01:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760363003/1
4 years, 9 months ago (2016-03-04 09:02:08 UTC) #3
commit-bot: I haz the power
Failed to apply the patch.
4 years, 9 months ago (2016-03-04 09:02:18 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 09:03:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec0f451b648e1e13afb00a3d2ec9e1f2e46107ec
Cr-Commit-Position: refs/heads/master@{#34482}

Powered by Google App Engine
This is Rietveld 408576698