Make tools/run_hooks.py work when depot_tools is not in PATH

Make tools/run_hooks.py work when depot_tools is not in PATH

It should be possible to create and build from a Mojo checkout even
when depot_tools is not in the PATH, even though many common
development workflows require it. This teaches tools/run_hooks.py to
add a default depot_tools location to the PATH that hooks run in so
that a jiri checkout can execute hooks without PATH modifications.

R=kulakowski@chromium.org, lanechr@google.com, viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/aab2a72a35eba483ac95207d3df1e808899d0573

[jamesr, 2016-03-04 02:23:44]

jamesr@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[jamesr, 2016-03-04 02:24:18]

Nick hit this when playing with the mojo jiri config.  While every mojo dev will
need depot_tools in their PATH developers who just want to consume mojo (and
possibly build it) but not make changes should be able to do that.

[kulakowski, 2016-03-04 17:28:19]

kulakowski@chromium.org changed reviewers:
+ kulakowski@chromium.org

[kulakowski, 2016-03-04 17:28:19]

not trung, but lgtm

[lanechr, 2016-03-04 17:35:40]

lanechr@google.com changed reviewers:
+ lanechr@google.com

[lanechr, 2016-03-04 17:35:41]

https://codereview.chromium.org/1760353002/diff/1/tools/run_hooks.py
File tools/run_hooks.py (right):

https://codereview.chromium.org/1760353002/diff/1/tools/run_hooks.py#newcode30
tools/run_hooks.py:30: if env["PATH"].find("depot_tools") == -1:
why not just add the default_depot_tools_path to the end of the PATH?  it would
better handle the case of the user having a depot_tools directory that doesn't
include the tool you want.  plus, this is kind of what PATH does.

[jamesr, 2016-03-04 19:26:14]

OK, done.

[lanechr, 2016-03-04 19:29:26]

On 2016/03/04 19:26:14, jamesr wrote:
> OK, done.

lgtm (also not trung)

[viettrungluu, 2016-03-04 20:46:10]

lgtm (not trung either)

https://codereview.chromium.org/1760353002/diff/40001/tools/run_hooks.py
File tools/run_hooks.py (right):

https://codereview.chromium.org/1760353002/diff/40001/tools/run_hooks.py#newc...
tools/run_hooks.py:32: env["PATH"] = env["PATH"] + ":" +
default_depot_tools_path
+= ?

(Also, I'd suggest os.pathsep instead of ":", but that seems lame.)

[jamesr, 2016-03-04 20:58:12]

Description was changed from

==========
Make tools/run_hooks.py work when depot_tools is not in PATH

It should be possible to create and build from a Mojo checkout even
when depot_tools is not in the PATH, even though many common
development workflows require it. This teaches tools/run_hooks.py to
add a default depot_tools location to the PATH that hooks run in so
that a jiri checkout can execute hooks without PATH modifications.
==========

to

==========
Make tools/run_hooks.py work when depot_tools is not in PATH

It should be possible to create and build from a Mojo checkout even
when depot_tools is not in the PATH, even though many common
development workflows require it. This teaches tools/run_hooks.py to
add a default depot_tools location to the PATH that hooks run in so
that a jiri checkout can execute hooks without PATH modifications.

R=kulakowski@chromium.org, lanechr@google.com, viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/aab2a72a35eba483ac95207d3df...
==========

[jamesr, 2016-03-04 20:58:14]

Committed patchset #3 (id:40001) manually as
aab2a72a35eba483ac95207d3df1e808899d0573 (presubmit successful).