Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1760343002: X87: [compiler] Introduce StringEqualStub and StringNotEqualStub. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Introduce StringEqualStub and StringNotEqualStub. port 2689548e38c68bb6294fed5e2d83feec67e3a1f4 (r34459) original commit message: These new stubs perform exactly the same job as the string equality case for the CompareIC, but are platform independent and usable outside of fullcodegen and Crankshaft. We use them in the StrictEqualStub and the StrictNotEqualStub instead of falling back to the runtime immediately for String comparisons, and we also use them in TurboFan to perform String equality or inequality comparisons. These stubs currently handle only internalized and one byte strings w/o going to C++, but it should be easy to add support for more string cases later, i.e. utilizing already flattened cons strings or comparing two byte strings as well. BUG= Committed: https://crrev.com/1a73d99e92febf6aba925c1d9abfd56bca3acae1 Cr-Commit-Position: refs/heads/master@{#34479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-04 01:54:47 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-04 05:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760343002/1
4 years, 9 months ago (2016-03-04 07:03:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:25:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:25:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a73d99e92febf6aba925c1d9abfd56bca3acae1
Cr-Commit-Position: refs/heads/master@{#34479}

Powered by Google App Engine
This is Rietveld 408576698