Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 176032: Adding commandline option to override bans on certain port numbers through a ... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 24426)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -37,6 +37,7 @@
#include "net/socket/ssl_test_util.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_file_dir_job.h"
+#include "net/url_request/url_request_http_job.h"
#include "net/url_request/url_request_test_job.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@@ -223,6 +224,21 @@
#endif
}
+TEST_F(URLRequestTestHTTP, SetExplicitlyAllowedPortsTest) {
+ std::wstring invalid[] = { L"1,2,a", L"'1','2'", L"1, 2, 3", L"1 0,11,12" };
+ std::wstring valid[] = { L"", L"1", L"1,2", L"1,2,3", L"10,11,12,13" };
+
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(invalid); ++i) {
+ URLRequestHttpJob::SetExplicitlyAllowedPorts(invalid[i]);
+ EXPECT_EQ(0, URLRequestHttpJob::explicitly_allowed_ports().size());
+ }
+
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(valid); ++i) {
+ URLRequestHttpJob::SetExplicitlyAllowedPorts(valid[i]);
+ EXPECT_EQ(i, URLRequestHttpJob::explicitly_allowed_ports().size());
+ }
+}
+
TEST_F(URLRequestTest, QuitTest) {
// Don't use shared server here because we order it to quit.
// It would impact other tests.
« net/url_request/url_request_http_job.cc ('K') | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698