Issue 176030: Update test expectations to account for a successful test on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176030: Update test expectations to account for a successful test on Mac (Closed)

Created:
11 years, 3 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update test expectations to account for a successful test on Mac. BUG=10416 TEST=Covered by layout test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24844

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years, 3 months ago (2009-08-29 01:10:31 UTC) #2

LGTM

On Fri, Aug 28, 2009 at 6:00 PM, <paul@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Update test expectations to account for a successful test on Mac.
>
> BUG=10416
> TEST=Covered by layout test.
>
>
> Please review this at http://codereview.chromium.org/176030
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24842)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1689,7 +1689,7 @@
>  BUG10411 : LayoutTests/svg/custom/gradient-stop-style-change.svg = FAIL
> PASS
>
>  // Rebaseline
> -BUG10416 :
> LayoutTests/fast/dynamic/insert-before-table-part-in-continuation.html =
> FAIL
> +BUG10416 WIN LINUX :
> LayoutTests/fast/dynamic/insert-before-table-part-in-continuation.html =
> FAIL
>
>  // New tests added in http://trac.webkit.org/changeset/40424
>  // Renders the width of "600" off by 3.  Looks OK but could still be a bug
>
>
>

Expand Messages | Collapse Messages