Linux: Simplify omnibox selection code and stop taking back selection.

Linux: Simplify omnibox selection code and stop taking back selection.

This fixes a long-time bug (mentioned at the end of my description
in http://codereview.chromium.org/159185 but reported more recently)
where Chrome would steal back the PRIMARY selection the first time
that another app takes it.

I tested by going through my test cases from the following earlier
changes and also confirming that the selection-stealing issue is also
fixed:

  http://codereview.chromium.org/151006
  http://codereview.chromium.org/155971
  http://codereview.chromium.org/159185
  http://codereview.chromium.org/164539
  http://codereview.chromium.org/173098

BUG=20460
TESTED=see above

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24971

[Daniel Erat, 2009-08-29 00:52:48]

http://codereview.chromium.org/176029/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/176029/diff/1/2#newcode887
Line 887: gtk_clipboard_get_owner(clipboard)) {
This part feels a bit strange to me but seems to work (i.e. we don't steal the
selection back if I start highlighting text in the find bar).

[Evan Stade, 2009-08-31 18:17:09]

overall lg, just one question

http://codereview.chromium.org/176029/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/176029/diff/1/2#newcode887
Line 887: gtk_clipboard_get_owner(clipboard)) {
is !IsSelectionOwned() insufficient on its own?

[use derat at chromium.org, 2009-08-31 23:00:09]

On Mon, Aug 31, 2009 at 11:17 AM, <estade@chromium.org> wrote:
> overall lg, just one question
>
>
> http://codereview.chromium.org/176029/diff/1/2
> File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):
>
> http://codereview.chromium.org/176029/diff/1/2#newcode887
> Line 887: gtk_clipboard_get_owner(clipboard)) {
> is !IsSelectionOwned() insufficient on its own?

Yes (this is what I tried first).  After a bit more testing, I think I
see the reason why -- this handler is connected before the default
handler, so when the user moves the mark by clicking in a different
area of the omnibox with the mouse, the selection is still owned by
the text buffer when this handler gets called.  I've removed
IsSelectionOwned() and replaced it with:

  gtk_clipboard_get_owner(clipboard) == G_OBJECT(text_buffer_)

, which works and makes more sense (updated the comment too).

> http://codereview.chromium.org/176029
>

[Evan Stade, 2009-08-31 23:31:23]

ok cool lgtm