Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1760273003: Added unittests for VideoDecoderConfig conversion. (Closed)

Created:
4 years, 9 months ago by alokp
Modified:
4 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added unittests for VideoDecoderConfig conversion. TEST=MediaTypeConvertersTest Committed: https://crrev.com/b1686822b15b6337c814ba4b6045b3eb4e4a21cd Cr-Commit-Position: refs/heads/master@{#379327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M media/mojo/common/media_type_converters.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M media/mojo/common/media_type_converters_unittest.cc View 4 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alokp
4 years, 9 months ago (2016-03-04 18:25:02 UTC) #2
xhwang
Thanks for catching the issue and the fix! LGTM
4 years, 9 months ago (2016-03-04 18:32:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760273003/1
4 years, 9 months ago (2016-03-04 18:38:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 19:26:14 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 19:27:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b1686822b15b6337c814ba4b6045b3eb4e4a21cd
Cr-Commit-Position: refs/heads/master@{#379327}

Powered by Google App Engine
This is Rietveld 408576698