Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 1760243004: Implement search for local elements. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement search for local elements. We don't use Index for them, instead of visit coresponding AST subtrees and add SearchMatch(es). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ec906bf12bd8376f64ebab1e6a6ce3066feb9768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -183 lines) Patch
M pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 3 chunks +113 lines, -100 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 5 chunks +100 lines, -83 lines 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-04 21:23:02 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-04 22:40:06 UTC) #2
scheglov
4 years, 9 months ago (2016-03-05 15:50:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec906bf12bd8376f64ebab1e6a6ce3066feb9768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698