Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: net/socket/client_socket_pool_base.h

Issue 176024: Make GetLoadState virtual in ConnectJob(). (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.h
diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h
index e6368ca1c61cd8ce9b2f7f7fb7670003c3dfb480..5689b85bb90a87bc44ed404b7e2ad8caae673f69 100644
--- a/net/socket/client_socket_pool_base.h
+++ b/net/socket/client_socket_pool_base.h
@@ -70,8 +70,8 @@ class ConnectJob {
// Accessors
const std::string& group_name() const { return group_name_; }
- LoadState load_state() const { return load_state_; }
const ClientSocketHandle* key_handle() const { return key_handle_; }
+ LoadLog* load_log() { return load_log_; }
// Releases |socket_| to the client. On connection error, this should return
// NULL.
@@ -85,10 +85,9 @@ class ConnectJob {
// if it succeeded.
int Connect();
- LoadLog* load_log() { return load_log_; }
+ virtual LoadState GetLoadState() const = 0;
protected:
- void set_load_state(LoadState load_state) { load_state_ = load_state; }
void set_socket(ClientSocket* socket) { socket_.reset(socket); }
ClientSocket* socket() { return socket_.get(); }
void NotifyDelegateOfCompletion(int rv);
@@ -106,7 +105,6 @@ class ConnectJob {
// Timer to abort jobs that take too long.
base::OneShotTimer<ConnectJob> timer_;
Delegate* delegate_;
- LoadState load_state_;
scoped_ptr<ClientSocket> socket_;
scoped_refptr<LoadLog> load_log_;
« no previous file with comments | « no previous file | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698