Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1760223002: [display] Add __BEGIN_CDECLS (Closed)

Created:
4 years, 9 months ago by cdotstout
Modified:
4 years, 9 months ago
Reviewers:
travisg1, gkalsi
Base URL:
https://github.com/littlekernel/lk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[display] Add __BEGIN_CDECLS R=travisg@gmail.com Committed: 00354ba7919ab15f63753398c2cd6c1f782dfdc5

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove semicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/dev/display.h View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cdotstout
4 years, 9 months ago (2016-03-03 18:45:49 UTC) #2
travisg1
https://codereview.chromium.org/1760223002/diff/1/include/dev/display.h File include/dev/display.h (right): https://codereview.chromium.org/1760223002/diff/1/include/dev/display.h#newcode31 include/dev/display.h:31: __BEGIN_CDECLS; These macros don't need the trailing semicolon, though ...
4 years, 9 months ago (2016-03-03 18:47:19 UTC) #3
cdotstout
https://codereview.chromium.org/1760223002/diff/1/include/dev/display.h File include/dev/display.h (right): https://codereview.chromium.org/1760223002/diff/1/include/dev/display.h#newcode31 include/dev/display.h:31: __BEGIN_CDECLS; On 2016/03/03 18:47:18, travisg1 wrote: > These macros ...
4 years, 9 months ago (2016-03-03 18:50:33 UTC) #4
travisg1
lgtm
4 years, 9 months ago (2016-03-03 18:51:54 UTC) #5
cdotstout
4 years, 9 months ago (2016-03-03 18:52:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
00354ba7919ab15f63753398c2cd6c1f782dfdc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698