content/browser/devtools/protocol/input_handler.cc - Issue 1760183002: Fixed missing pointerTypes for touch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/input_handler.cc

Issue 1760183002: Fixed missing pointerTypes for touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android hover event type. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/input_handler.cc

diff --git a/content/browser/devtools/protocol/input_handler.cc b/content/browser/devtools/protocol/input_handler.cc

index d9c17f3ee0e31fcdfe16e7f6c0785b4df16b9433..e466bf1e9b44af1d047e089731cc4738deddbc0c 100644

--- a/content/browser/devtools/protocol/input_handler.cc

+++ b/content/browser/devtools/protocol/input_handler.cc

@@ -248,6 +248,7 @@ Response InputHandler::DispatchMouseEvent(

event.globalX = x * page_scale_factor_;

event.globalY = y * page_scale_factor_;

event.clickCount = click_count ? *click_count : 0;

+ event.pointerType = blink::WebPointerProperties::PointerType::Mouse;

if (!host_)

return Response::ServerError("Could not connect to view");

@@ -296,6 +297,7 @@ Response InputHandler::EmulateTouchFromMouseEvent(const std::string& type,

event->globalX = x;

event->globalY = y;

event->clickCount = click_count ? *click_count : 0;

+ event->pointerType = blink::WebPointerProperties::PointerType::Touch;

if (!host_)

return Response::ServerError("Could not connect to view");