Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 176018: Merge 24736 - Change default homepage experience.... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 24736 - Change default homepage experience. We want to make google.com homepage by default and also show the home button (see the bug below). BUG=http://crbug.com/19392 TEST=Delete user profile and launch Chrome homepage should be set to google.com and should be enabled. also home button should show up. Review URL: http://codereview.chromium.org/174030 TBR=kuchhal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
MM chrome/browser/browser.h View 1 chunk +6 lines, -0 lines 0 comments Download
MM chrome/browser/browser.cc View 2 chunks +9 lines, -0 lines 0 comments Download
MM chrome/browser/browser_main.cc View 1 chunk +7 lines, -4 lines 0 comments Download
MM chrome/browser/google_url_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 3 months ago (2009-08-28 18:11:25 UTC) #1
kuchhal
11 years, 3 months ago (2009-08-28 18:20:22 UTC) #2
lgtm.

On Fri, Aug 28, 2009 at 11:11 AM, <laforge@chromium.org> wrote:

> Reviewers: kuchhal,
>
> Description:
> Merge 24736 - Change default homepage experience.
>
> We want to make google.com homepage by default and also show the home
> button (see the bug below).
>
> BUG=http://crbug.com/19392
> TEST=Delete user profile and launch Chrome  homepage should be set to
> google.com and should be enabled. also home button should show up.
>
> Review URL: http://codereview.chromium.org/174030
>
> TBR=kuchhal@chromium.org
>
>
> Please review this at http://codereview.chromium.org/176018
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
>  MM    chrome/browser/browser.h
>  MM    chrome/browser/browser.cc
>  MM    chrome/browser/browser_main.cc
>  MM    chrome/browser/google_url_tracker.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698