Avoid drawing NVPR DIF text when text size is 0

Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760163002

Committed: https://skia.googlesource.com/skia/+/68c63b3727f05638a95fcf5f65c5476a2fcb34d0

[Kimmo Kinnunen, 2016-03-03 13:59:47]

Description was changed from

==========
Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
==========

to

==========
Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-03-03 14:00:35]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2016-03-03 14:00:35]

Not sure to which level we should propagate the text drawing calls with text
size == 0, until we know it can be skipped without side effects.

[Kimmo Kinnunen, 2016-03-03 14:02:24]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 14:02:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760163002/1

[commit-bot: I haz the power, 2016-03-03 14:02:30]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-03-03 20:02 UTC

[bsalomon, 2016-03-03 14:26:01]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com, jvanverth@google.com

[bsalomon, 2016-03-03 14:26:01]

Over to Joshua and Jim

[joshualitt, 2016-03-03 14:28:14]

On 2016/03/03 14:26:01, bsalomon wrote:
> Over to Joshua and Jim

Looks fine to me, Jim do you have any objections?

[jvanverth1, 2016-03-03 15:29:06]

lgtm + nit

https://codereview.chromium.org/1760163002/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1760163002/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:232: SkDEBUGCODE(
Is there a reason this (and the change below it) is formatted like this? It
looks like it would fit on one line.

[commit-bot: I haz the power, 2016-03-03 15:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 15:31:18]

Dry run: This issue passed the CQ dry run.

[Kimmo Kinnunen, 2016-03-04 08:03:07]

thanks

https://codereview.chromium.org/1760163002/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1760163002/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:232: SkDEBUGCODE(
On 2016/03/03 15:29:06, jvanverth1 wrote:
> Is there a reason this (and the change below it) is formatted like this? It
> looks like it would fit on one line.

Done.

[Kimmo Kinnunen, 2016-03-04 08:03:15]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-03-04 08:03:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1760163002/#ps20001
(title: "address review comment")

[commit-bot: I haz the power, 2016-03-04 08:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760163002/20001

[commit-bot: I haz the power, 2016-03-04 08:12:37]

Description was changed from

==========
Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/68c63b3727f05638a95fcf5f65c5476a2fcb34d0
==========

[commit-bot: I haz the power, 2016-03-04 08:12:38]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/68c63b3727f05638a95fcf5f65c5476a2fcb34d0