Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1760153003: VM: Don't do inline context allocation in precompiled code. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Don't do inline context allocation in precompiled code. It saves almost 2% (dart2js) in generated snapshot size, and the performance benefit is negligible in precompiled code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/69f39d0b83cd0fb22196f8bccbf1cb9c566b4dba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M runtime/vm/aot_optimizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 9 months ago (2016-03-04 00:16:25 UTC) #3
rmacnak
lgtm
4 years, 9 months ago (2016-03-04 00:19:06 UTC) #4
Florian Schneider
4 years, 9 months ago (2016-03-04 00:22:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69f39d0b83cd0fb22196f8bccbf1cb9c566b4dba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698